Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will address #69. Includes some pretty major changes but is currently broken; will force push and break up into smaller commits on some later date.
Edit: I think the best approach may be to entirely subclass/replace
RcParams, monkey patchmatplotlib.rcParams, and simply haveproplot.rcpoint tomatplotlib.rcParams. This will let me implement some other features, e.g. arbitrary units for matplotlib params with conversion upon callingRcParams.__getitem__, and keeps me from having to store separate dictionaries. The sections on the website docs will instead read "Shorthand params" and "rcParams additions"; the former will be implemented only inRcParams.__setitem__, and the latter will be literally added as validmatplotlib.rcParams. This will be yet another exercise in integrating proplot's internals more closely with the matplotlib API; wish I had looked at the matplotlib source code more in the early days of development.